Skip to content

Fixes 15 #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aarond10 merged 3 commits into from
May 11, 2025
Merged

Fixes 15 #185

aarond10 merged 3 commits into from
May 11, 2025

Conversation

@baranyaib90
Copy link
Contributor

@baranyaib90 baranyaib90 commented May 11, 2025 •
edited
Loading

Hi Aaron,
I hope you are doing well! Here is nothing special, just the usual: a few code changes.

  1. Fixing ring_buffer.h define of my previous pull request
  2. To improve debugging, now I set to log HTTPS request and response content (so the DNS request and reply) as well on debug level. I hope this could help debugging future issues. Obviously users still can decide not to share these lines when opening an issue here.
  3. I have improved the version printing to fix Querying libcurl4 for http2/http3 support #183 As I implemented it, I tried to improve the code a bit. (switch-case of options_parse_args() got a bit large, but I tried to make it clean and simple :S)
    Example printout:
$ ./https_dns_proxy -V
2025.05.10-20a4f43
Using: ev/4.33 c-ares/1.33.0 libcurl/8.12.1-DEV quictls/3.1.4 zlib/1.3.1 brotli/1.1.0 zstd/1.5.6 libidn2/2.3.7 libpsl/0.21.2 nghttp2/1.64.0 ngtcp2/1.2.0 nghttp3/1.1.0 librtmp/2.3
Features: HTTP2 HTTP3 HTTPS-proxy IPv6

Take your time.
Best regards,
Balázs

@baranyaib90
Fixing ring_buffer.h define
ef05120
@baranyaib90
Debug log HTTPS request and response data
e6fd23c
@baranyaib90
Printing curl library versions and used features
83f7e92 
- Moved argument parsing "decisions" into main()
- getopt() handling changes, test OPR_PARSING_ERROR
  with "-j" and "-i" argument strings.
- Minimal libcurl version raised to 7.66.0, so
  no need to check CURL_VERSION_HTTP3 availability.
- Raised hardcoded version.
@aarond10 aarond10 merged commit a34e20d into aarond10:master May 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aarond10 aarond10 aarond10 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Querying libcurl4 for http2/http3 support

2 participants

@baranyaib90 @aarond10