Fixes 14 #182
Merged
Fixes 14 #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In current commit the important part is to avoid process exit and recover from faulty state, even when every ongoing request has to be dropped.
To have debug logs dump before FLOG panic and when it is necessary when debugging a rare issue. In options_cleanup() according to valgrind not closing logfd if it is the default stdout.
A few curl version after 8.9.0 kept connections opened which did not count in CURLMOPT_MAX_TOTAL_CONNECTIONS limit. Therefore more IO events are necessary to handle more sockets than we expect. Details in: curl/curl#15857
It was not working at all before. Better to get rid of TCP keepalive since it was not necessary. Raising curl requirement level because of option. It has been made configurable via argument, because different DoH server providers have different timeouts configured.
When a large burst of DNS requests came in and the only HTTPS/2 connection was too many time in idle state, curl closes it and opens brand new connection for every single DNS request. Obviously later it will keep only 1 and close all the others. So it is better to wait for multiplexing. When testing this setting, the DNS query latency values did not raise.
If we already have a connection 5 second should be enough, else leave time for connecting to server. Goal is to fail faster if some reused HTTPS connection was idle for way too many time and it is actually not working anymore.
It was quite a mess and inconsistent. It will not be perfect with this change, but still better. In case of boolean options, default values are omitted.
aarond10
approved these changes
Mar 11, 2025
aarond10
reviewed
Mar 12, 2025
| @@ -0,0 +1,21 @@ | |||
| #ifndef _FR_H_ | |||
Contributor
Author
There was a problem hiding this comment.
I will try not to forget to fix later.
aarond10
approved these changes
Mar 12, 2025
aarond10
approved these changes
Mar 12, 2025
aarond10
approved these changes
Mar 12, 2025
aarond10
approved these changes
Mar 13, 2025
aarond10
approved these changes
Mar 13, 2025
aarond10
approved these changes
Mar 13, 2025
aarond10
approved these changes
Mar 13, 2025
Owner
|
Thanks for the commits! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Aaron,
I'm sorry, because this one will be quite a large pack :(
I hope commit messages are good enough to detail the changes.
Highlights:
Best regards,
Balázs