fix: immediately halt execution on assert(false) #572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daejunpark
force-pushed
the
fix/assert-false
branch
from
28abb19 to
98a8d2a
Compare
daejunpark
force-pushed
the
fix/assert-false
branch
from
98a8d2a to
e455107
Compare
0xkarmacoma
reviewed
Aug 4, 2025
| if funsig in assert_cheatcode_handler: | ||
| vm_assert = assert_cheatcode_handler[funsig](arg) | ||
| not_cond = simplify(Not(vm_assert.cond)) | ||
| cond = vm_assert.cond |
Contributor
There was a problem hiding this comment.
do we guarantee that vm_assert.cond is already simplify'ed?
Collaborator
Author
There was a problem hiding this comment.
it will be simplified later during ex.check().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes foundry-rs/forge-std#705
previously, halmos didn't immediately halt execution for trivially false assertions, e.g., assert(false). this became problematic with the updated forge-std assertion logic (foundry-rs/forge-std#693), as it led to path explosion in complex tests like snekmate.
this pr fixes the behavior: when an assertion condition is trivially unsat, its execution path is now halted immediately.