handle failed solver processes #567
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daejunpark
force-pushed
the
fix/solver-process-exception
branch
from
35b0b45 to
e3b548b
Compare
0xkarmacoma
reviewed
Jul 28, 2025
| REVERT_ALL, | ||
| f"{funsig}: all paths have been reverted; the setup state or inputs may have been too restrictive.", | ||
| ) | ||
| elif len(ctx.solver_outputs) < len(submitted_futures): |
Contributor
There was a problem hiding this comment.
I'm a bit concerned about relying on the number of solver outputs to infer that an error occured
when an exception is raised in solver subprocesses, their result may not be added to the solver_outputs list
this seems to be the real issue? ideally we want to capture the errors and add failed outputs to ctx.solver_outputs, no?
Collaborator
Author
There was a problem hiding this comment.
ideally we want to capture the errors and add failed outputs to ctx.solver_outputs, no?
yes, but it needs some more work, as the solver output object currently needs more info that isn't available at some places exceptions occur.
Collaborator
Author
|
superseded by #570 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when an exception is raised in solver subprocesses, their result may not be added to the solver_outputs list. in the current implementation, if all processes fail due to exceptions, it may incorrectly return pass because no error solver outputs are recorded.
this pr adds logic to detect such cases by comparing the number of solver outputs with the number of solver processes. the detection is designed to distinguish these from early exit scenarios.