Fix S2201: Replace .map() with for...of in player pause handling #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

jayamrutiya wants to merge 1 commit into Zooz:master from jayamrutiya:letmecheck/bug-S2201-forof-player-pause

jayamrutiya commented Sep 19, 2025

Question	Answer
Bug fix	✔
New feature	✖
Breaking change	✖
Deprecations	✖
Documentation	✖
Tests added	✔

Further information:

Overview

This PR fixes a SonarQube issue (javascript:S2201) where the return
value of Array.prototype.map() was ignored in the player pause logic.

Changes

Replaced .map() with a for...of loop for better readability.
Ensured player pause functionality remains unchanged.
Removed unnecessary return value creation to comply with Sonar rules.

Why

.map() is meant for transforming arrays, but the returned value was
not being used.
Using for...of clarifies the intention (iteration for side effects).
Resolves Sonar warning S2201: Return values should not be ignored.

Testing

Verified that all players are paused correctly.
No change in functionality, only code quality improvement.


          Fix(S2201): replace .map() with for...of in player pause logic

9acce0d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet