Skip to content

esp: spi: Fix connect_pins #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tact1m4n3 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

esp: spi: Fix connect_pins #896

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e37ce1a
esp: spi: Fix `connect_pins`
tact1m4n3 Feb 2, 2026
07c6f69
Merge branch 'main' into esp_spi_fix
tact1m4n3 Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions port/espressif/esp/src/hal/spi.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,6 @@ pub const SPI = enum(u2) {
self.set_bit_order(config.bit_order);
}

// TODO: not sure if this is the best way to do this
pub inline fn connect_pins(_: SPI, pins: struct {
data: union(enum) {
single_one_wire: ?gpio.Pin,
Expand Down Expand Up @@ -188,7 +187,7 @@ pub const SPI = enum(u2) {
},
.single_two_wires => |maybe_pins| {
if (maybe_pins.mosi) |mosi| {
mosi.connect_input_to_peripheral(.{ .signal = .fspid });
mosi.connect_peripheral_to_output(.{ .signal = .fspid });
}
if (maybe_pins.miso) |miso| {
miso.connect_input_to_peripheral(.{ .signal = .fspiq });
Expand Down Expand Up @@ -223,6 +222,10 @@ pub const SPI = enum(u2) {
}
},
}

if (pins.clk) |clk_pin| {
clk_pin.connect_peripheral_to_output(.{ .signal = .spiclk });
}
}

pub fn writev_blocking(
Expand Down
Loading