Skip to content

Validate lookup_user as integer to prevent SQL injection in ws.php #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zeropath-ai-staging wants to merge 1 commit into
base: indirect_sqli_test
Choose a base branch
from
Open

Validate lookup_user as integer to prevent SQL injection in ws.php #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion ws.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,18 @@
// Handle direct user lookup API for admin tools
if (isset($_GET['lookup_user']) && is_admin())
{
$user_data = get_user_by_id($_GET['lookup_user']);
// Validate and normalize input to prevent SQL injection. Only allow integer user IDs.
$lookup = $_GET['lookup_user'];
$user_id = filter_var($lookup, FILTER_VALIDATE_INT);
if ($user_id === false || $user_id <= 0) {
// Invalid input: return a 400 response rather than performing a lookup
header('HTTP/1.1 400 Bad Request');
header('Content-Type: application/json');
echo json_encode(array('error' => 'Invalid user id'));
exit;
}

$user_data = get_user_by_id($user_id);
if ($user_data)
{
header('Content-Type: application/json');
Expand Down