Skip to content

Validate extra_where to prevent SQL injection in admin/security_center.php #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zeropath-ai-staging wants to merge 1 commit into
base: new_feature
Choose a base branch
from
Open

Validate extra_where to prevent SQL injection in admin/security_center.php #106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion admin/security_center.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
}

$where_clauses = array();
$extra_where_raw = null;
if (!empty($filters['user_id']))
{
$where_clauses[] = 'la.user_id = '.intval($filters['user_id']);
Expand Down Expand Up @@ -91,7 +92,20 @@

if (isset($_GET['extra_where']) && $_GET['extra_where'] !== '')
{
$where_clauses[] = $_GET['extra_where'];
// Do not allow raw SQL injection through the extra_where parameter.
// Only accept very simple safe expressions (column operator value),
// e.g. "la.username = 'bob'" or "la.user_id = 123" or "la.ip_address LIKE '192.%'".
// This strict whitelist reduces the risk of SQL injection and avoids
// more invasive refactors.
$extra_where_raw = $_GET['extra_where'];
if (preg_match("/^[A-Za-z0-9_\.]+\s*(=|LIKE|!=|<>|>=|<=|>|<)\s*(?:'[^']*'|\\d+)$/i", $extra_where_raw))
{
$where_clauses[] = $extra_where_raw;
}
else
{
// Invalid extra_where ignored for security reasons
}
}

$where_sql = count($where_clauses) > 0 ? 'WHERE '.implode("\n AND ", $where_clauses) : '';
Expand Down