Feature/mas 514 #47
Merged
Feature/mas 514 #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sGeeK44
commented
Sep 18, 2025
sGeeK44
commented
Sep 18, 2025
sGeeK44
force-pushed
the
feature/mas-514
branch
from
abebbba to
032ec1d
Compare
sGeeK44
commented
Sep 18, 2025
sGeeK44
commented
Sep 18, 2025
sGeeK44
commented
Sep 18, 2025
Contributor
antoine-b-smartway
left a comment
antoine-b-smartway
left a comment
There was a problem hiding this comment.
Je ne m'attendais pas à ce que ça implique autant de modifications partout mais effectivement si on veut le faire au champ il n'y a pas trop de choix.
Je pense qu'il faut dès le départ renvoyer les lignes ignorées pour mettre des logs sinon ça va être compliqué pour le support.
sGeeK44
force-pushed
the
feature/mas-514
branch
from
032ec1d to
a4f3000
Compare
sGeeK44
force-pushed
the
feature/mas-514
branch
from
a4f3000 to
71e2805
Compare
Contributor
antoine-b-smartway
left a comment
antoine-b-smartway
left a comment
There was a problem hiding this comment.
J'aime bien le nouveau retour, c'est beaucoup plus clair. Par contre je pense qu'il faut conserver une liste d'erreurs pour chaque ligne en erreur.
sGeeK44
force-pushed
the
feature/mas-514
branch
from
71e2805 to
ded8fb3
Compare
sGeeK44
force-pushed
the
feature/mas-514
branch
from
ded8fb3 to
75bca1b
Compare
sGeeK44
force-pushed
the
feature/mas-514
branch
from
770b666 to
31b8e4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Il manque la documentation, mais ça n'empêche pas de commencer à relire :)