feat: Added tanstack start plugin #255
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 0207fd0
☁️ Nx Cloud last updated this comment at |
5 tasks
swalker326
changed the title
swalker326
had a problem deploying
to
canary-publishing
GitHub Actions
Failure
swalker326
had a problem deploying
to
canary-publishing
GitHub Actions
Failure
swalker326
had a problem deploying
to
canary-publishing
GitHub Actions
Failure
swalker326
had a problem deploying
to
canary-publishing
GitHub Actions
Failure
swalker326
temporarily deployed
to
canary-publishing
GitHub Actions
Inactive
swalker326
had a problem deploying
to
canary-publishing
GitHub Actions
Failure
swalker326
had a problem deploying
to
canary-publishing
GitHub Actions
Failure
swalker326
temporarily deployed
to
canary-publishing
GitHub Actions
Inactive
swalker326
temporarily deployed
to
canary-publishing
GitHub Actions
Inactive
zackarychapple
previously approved these changes
Dec 12, 2025
Nsttt
approved these changes
Dec 13, 2025
| function getAssetType(item: { fileName?: string; name?: string }): string { | ||
| const fileName = item.fileName || item.name || ''; | ||
| const ext = path.extname(fileName).toLowerCase(); | ||
| const typeMap: Record<string, string> = { |
Member
There was a problem hiding this comment.
workers don't support commonsjs
Comment on lines
+115
to
+116
| console.log(`[TanStack Zephyr] Output directory: ${outputDir}`); | ||
| console.log(`[TanStack Zephyr] Server entrypoint: ${entrypoint}`); |
Member
There was a problem hiding this comment.
Should we remove these logs and make it use Zephyrs ?
| "zephyr-agent": "workspace:*" | ||
| }, | ||
| "peerDependencies": { | ||
| "@tanstack/start": "^1.0.0" |
Member
There was a problem hiding this comment.
Shouldn't this be @tanstack/react-start ?
Suggested change
| "@tanstack/start": "^1.0.0" | |
| "@tanstack/react-start": "^1.0.0" |
StashBank
approved these changes
Dec 15, 2025
| import type { OutputBundle, OutputAsset, OutputChunk } from 'rollup'; | ||
|
|
||
| /** Recursively get all files in a directory */ | ||
| async function getAllFiles(dir: string, baseDir?: string): Promise<string[]> { |
Member
There was a problem hiding this comment.
doesn't node have a fs.readdir(dirPath, { recursive: true })?
|
|
||
| // Load ALL build output preserving directory structure | ||
| // This includes server/, client/, and any root files (favicon.ico, etc.) | ||
| const bundle = await loadTanStackOutput(outputDir); |
Member
There was a problem hiding this comment.
I assume this is more a question than a review comment, but couldn't we hijack the onGenerateBundle from Vite's to grab all built assets instead of having to read dist folder and all complications it have?
artem-sht
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's added in this PR?
Screenshots
What's the issues or discussion related to this PR ?
What are the steps to test this PR?
Documentation update for this PR (if applicable)?
(Optional) What's left to be done for this PR?
(Optional) What's the potential risk and how to mitigate it?
(Required) Pre-PR/Merge checklist