-
Notifications
You must be signed in to change notification settings - Fork 25
Adding public headers into include directory #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #150 +/- ##
=======================================
Coverage 66.08% 66.08%
=======================================
Files 88 88
Lines 11265 11265
=======================================
Hits 7445 7445
Misses 3820 3820
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder whether line 422-423 needs to be adapted as well. I guess we'll need to test a vcpkg-build for this.
|
I wonder... while we are at it, should we move all other files in the the libCZI-folder (i.e. everything but the new inc-folder) into a new folder "src" (or something like this). Would this look "more tidy"? |
I think the same, since together with src folder, people will understand the purpose of the folders more easily. |
Description
Refactoring folder layout.
Moving
libCZIPublicHeadersfiles into the newly createdincdirectory for separate the public and private header files.Fixes # (issue)
Type of change
Refactoring folder layout
How Has This Been Tested?
With the new folder layout, I run unit tests of libczi and downstream projects (LibCZI_NET, imgdoc2).
Checklist: