Conversation
Must be over 1.14 to trigger automatic vendoring for potential linter usage. Should not impact building for JESSIE (testing).
Contributor
Author
|
@JeffB42 - As you can tell, I am going through all of last years PRs, let me know if you want to me to look back into this, or any of the others. |
Collaborator
|
I'm looking into the performance issues and I'm in the middle of doing some rewriting of the state machine. In some places there are some large changes. Because of this, I'd suggest holding off. When I get closer to getting the next release stable, I'll create a branch & at-mention you & let you know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Must be over 1.14 to trigger automatic vendoring for potential linter usage.
Does not impact building for JESSIE, or the build process as it is currently executed.
Does set the stage for simplifying the build process, however (no need for copying the whole system to go-root, path trimming, etc).
This lacks the "required" modules for a reason, we should discuss that reason before merging this.