Skip to content

experiment: use std::unordered_map in Looper instead of std::map #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YukunJ wants to merge 3 commits into
base: main
Choose a base branch
from
Open

experiment: use std::unordered_map in Looper instead of std::map #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8336a3
experiment: use std::unordered_map in Looper instead of std::map
Feb 7, 2023
551ef23
Merge branch 'main' into unordered_map
YukunJ Feb 16, 2023
0346b9a
experiment: boost::unordered_flag_map
YukunJ Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ ENDIF()
# Find the required thread package on the platform
SET(THREADS_PREFER_PTHREAD_FLAG ON)
FIND_PACKAGE(Threads REQUIRED)

FIND_PACKAGE(Boost REQUIRED)
include_directories(${Boost_INCLUDE_DIRS})
# Formatting utility search path
set(TURTLE_SERVER_BUILD_SUPPORT_DIR "${CMAKE_SOURCE_DIR}/build_support")
set(TURTLE_SERVER_CLANG_SEARCH_PATH "/usr/local/bin" "/usr/bin" "/usr/local/opt/llvm/bin" "/usr/local/opt/llvm@8/bin" "/usr/local/Cellar/llvm/8.0.1/bin")
Expand Down
1 change: 0 additions & 1 deletion src/include/core/connection.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
#include <string>
#include <utility>
#include <vector>

#include "core/buffer.h"
#include "core/socket.h"
#include "core/utils.h"
Expand Down
3 changes: 2 additions & 1 deletion src/include/core/looper.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
#include <functional>
#include <future> // NOLINT
#include <map>
#include <boost/unordered/unordered_flat_map.hpp>
#include <memory>
#include <mutex> // NOLINT

Expand Down Expand Up @@ -59,7 +60,7 @@ class Looper {
private:
std::unique_ptr<Poller> poller_;
std::mutex mtx_;
std::map<int, std::unique_ptr<Connection>> connections_;
boost::unordered_flat_map<int, std::unique_ptr<Connection>> connections_;
bool exit_{false};
};
} // namespace TURTLE_SERVER
Expand Down