Skip to content

Feature/azem2 1972 update phpcs and phpmd rules to fit magento#66

Open
CyberSecutor wants to merge 6 commits intoYouweGit:masterfrom
CyberSecutor:feature/AZEM2-1972-Update-phpcs-rules-to-fit-magento
Open

Feature/azem2 1972 update phpcs and phpmd rules to fit magento#66
CyberSecutor wants to merge 6 commits intoYouweGit:masterfrom
CyberSecutor:feature/AZEM2-1972-Update-phpcs-rules-to-fit-magento

Conversation

@CyberSecutor
Copy link

No description provided.

Copy link
Member

@Anve94 Anve94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approved but strong recommend to specify changelog with what actually changed, e.g.:

  • Increased cyclomatic complexity limit in Magento ruleset to allow for larger dependency chains that are common in Magento DI
  • Allow unused formal parameters in Magento ruleset to have better support for the Magento plugin system using a $subject reference.

and to not exclude unused local variables (params are fine for Plugins using $subject or just because the order of params is important for plugins), but unused local variables are practically always just dead code (at least I certainly cannot think of an exception where it might be warranted)

Also suggest to squash the commits since it's all one feature, and that makes the diff easier to find/read/compare later instead of git blame showing 3 or 4 commits for one feature.

@CyberSecutor CyberSecutor force-pushed the feature/AZEM2-1972-Update-phpcs-rules-to-fit-magento branch from c27310b to 671b6ad Compare February 2, 2026 14:38
@CyberSecutor CyberSecutor changed the title Feature/azem2 1972 update phpcs rules to fit magento and add placeholders for drupal and pimcore Feature/azem2 1972 update phpcs and phpmd rules to fit magento Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants