Feature/azem2 1972 update phpcs and phpmd rules to fit magento#66
Open
CyberSecutor wants to merge 6 commits intoYouweGit:masterfrom
Open
Conversation
added 2 commits
January 28, 2026 15:09
…eholders for drupal and pimcore
Anve94
requested changes
Jan 30, 2026
Anve94
approved these changes
Feb 2, 2026
Member
There was a problem hiding this comment.
Pre-approved but strong recommend to specify changelog with what actually changed, e.g.:
- Increased cyclomatic complexity limit in Magento ruleset to allow for larger dependency chains that are common in Magento DI
- Allow unused formal parameters in Magento ruleset to have better support for the Magento plugin system using a
$subjectreference.
and to not exclude unused local variables (params are fine for Plugins using $subject or just because the order of params is important for plugins), but unused local variables are practically always just dead code (at least I certainly cannot think of an exception where it might be warranted)
Also suggest to squash the commits since it's all one feature, and that makes the diff easier to find/read/compare later instead of git blame showing 3 or 4 commits for one feature.
c27310b to
671b6ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.