Add missing parameter to TextWidth usage in string_width.#700
Open
eshtol wants to merge 1 commit intoYoYoGames:developfrom
Open
Add missing parameter to TextWidth usage in string_width.#700eshtol wants to merge 1 commit intoYoYoGames:developfrom
eshtol wants to merge 1 commit intoYoYoGames:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello again!
One issue I mentioned in my game built with develop HTML5 runner is that string_width returns nan (missed pulsing tip text in the middle of the screen).
In addition to 65e9ed2, I specified parameters to TextWidth call (the missed one usage).
Have a nice day!