Adjust weak_ref_alive to allow for "undefined" to match VM behavior#675
Open
nommiin wants to merge 1 commit intoYoYoGames:developfrom
Open
Adjust weak_ref_alive to allow for "undefined" to match VM behavior#675nommiin wants to merge 1 commit intoYoYoGames:developfrom
nommiin wants to merge 1 commit intoYoYoGames:developfrom
Conversation
Author
|
Checking through the codebase, maybe it makes more sense to check if there's explicitly 1 argument but alas... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, passing
undefinedintoweak_ref_aliveon HTML5 will causeyyError("incorrect number of arguments to weak_ref_alive");to be thrown. On VM/YYC, the function will returnundefinedwithout error.This behavior does not match what occurs on VM (and YYC) and what is stated in the documentation:
My PR adjusts
weak_ref_aliveto instead check if any arguments are provided, rather than checking for undefined. This brings the functionality to match VM and YYC as of beta v2024.1400.0.836