Support front-matter in the issue content #7

CloudyCity · 2021-06-02T10:51:14Z

Yikun · 2021-06-03T02:48:33Z

# hexo migrate github-issue Yikun/hexo-migrator-github-issue
INFO  Validating config
INFO  Migrate from Yikun/hexo-migrator-github-issue...
INFO  create post: [Test] Issue
INFO  create post: Support front-matter in the issue content
INFO  create post: 兼容更多Meta
Unhandled rejection YAMLException: bad indentation of a mapping entry (1:15)

 1 | title: [Test] Issue
-------------------^
 2 | date: 2021-06-03 02:45:20
 3 | tags:
    at generateError (/root/test/node_modules/js-yaml/lib/loader.js:183:10)
    at throwError (/root/test/node_modules/js-yaml/lib/loader.js:187:9)
    at readBlockMapping (/root/test/node_modules/js-yaml/lib/loader.js:1182:7)
    at composeNode (/root/test/node_modules/js-yaml/lib/loader.js:1441:12)
    at readDocument (/root/test/node_modules/js-yaml/lib/loader.js:1625:3)
    at loadDocuments (/root/test/node_modules/js-yaml/lib/loader.js:1688:5)
    at load (/root/test/node_modules/js-yaml/lib/loader.js:1714:19)
    at /root/test/node_modules/hexo/lib/hexo/post.js:152:63
    at tryCatcher (/root/test/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/root/test/node_modules/bluebird/js/release/promise.js:547:31)
    at Promise._settlePromise (/root/test/node_modules/bluebird/js/release/promise.js:604:18)
    at Promise._settlePromise0 (/root/test/node_modules/bluebird/js/release/promise.js:649:10)
    at Promise._settlePromises (/root/test/node_modules/bluebird/js/release/promise.js:729:18)
    at Promise._fulfill (/root/test/node_modules/bluebird/js/release/promise.js:673:18)
    at Promise._settlePromise (/root/test/node_modules/bluebird/js/release/promise.js:617:21)
    at Promise._settlePromise0 (/root/test/node_modules/bluebird/js/release/promise.js:649:10)
    at Promise._settlePromises (/root/test/node_modules/bluebird/js/release/promise.js:729:18)
    at Promise._fulfill (/root/test/node_modules/bluebird/js/release/promise.js:673:18)
    at /root/test/node_modules/bluebird/js/release/nodeback.js:42:21
    at /root/test/node_modules/nunjucks/src/environment.js:41:5
    at RawTask.call (/root/test/node_modules/asap/asap.js:40:19)
    at flush (/root/test/node_modules/asap/raw.js:50:29)

yaml中有特殊字符的话会break

index.js

package.json

CloudyCity · 2021-06-03T07:26:48Z

# hexo migrate github-issue Yikun/hexo-migrator-github-issue
INFO  Validating config
INFO  Migrate from Yikun/hexo-migrator-github-issue...
INFO  create post: [Test] Issue
INFO  create post: Support front-matter in the issue content
INFO  create post: 兼容更多Meta
Unhandled rejection YAMLException: bad indentation of a mapping entry (1:15)

 1 | title: [Test] Issue
-------------------^
 2 | date: 2021-06-03 02:45:20
 3 | tags:
    at generateError (/root/test/node_modules/js-yaml/lib/loader.js:183:10)
    at throwError (/root/test/node_modules/js-yaml/lib/loader.js:187:9)
    at readBlockMapping (/root/test/node_modules/js-yaml/lib/loader.js:1182:7)
    at composeNode (/root/test/node_modules/js-yaml/lib/loader.js:1441:12)
    at readDocument (/root/test/node_modules/js-yaml/lib/loader.js:1625:3)
    at loadDocuments (/root/test/node_modules/js-yaml/lib/loader.js:1688:5)
    at load (/root/test/node_modules/js-yaml/lib/loader.js:1714:19)
    at /root/test/node_modules/hexo/lib/hexo/post.js:152:63
    at tryCatcher (/root/test/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/root/test/node_modules/bluebird/js/release/promise.js:547:31)
    at Promise._settlePromise (/root/test/node_modules/bluebird/js/release/promise.js:604:18)
    at Promise._settlePromise0 (/root/test/node_modules/bluebird/js/release/promise.js:649:10)
    at Promise._settlePromises (/root/test/node_modules/bluebird/js/release/promise.js:729:18)
    at Promise._fulfill (/root/test/node_modules/bluebird/js/release/promise.js:673:18)
    at Promise._settlePromise (/root/test/node_modules/bluebird/js/release/promise.js:617:21)
    at Promise._settlePromise0 (/root/test/node_modules/bluebird/js/release/promise.js:649:10)
    at Promise._settlePromises (/root/test/node_modules/bluebird/js/release/promise.js:729:18)
    at Promise._fulfill (/root/test/node_modules/bluebird/js/release/promise.js:673:18)
    at /root/test/node_modules/bluebird/js/release/nodeback.js:42:21
    at /root/test/node_modules/nunjucks/src/environment.js:41:5
    at RawTask.call (/root/test/node_modules/asap/asap.js:40:19)
    at flush (/root/test/node_modules/asap/raw.js:50:29)

yaml中有特殊字符的话会break

能否提供下yaml内容？

Yikun · 2021-06-03T10:26:58Z

@CloudyCity
用这个命令可以复现：hexo migrate github-issue Yikun/hexo-migrator-github-issue

但和你这个patch无关应该，旧版本也有问题。
复现用例：#9
issue：#10

Yikun · 2021-06-03T10:54:18Z

package.json

@@ -4,7 +4,8 @@
  "description": "Github issue migrator plugin for Hexo.",


"version": "0.1.5" 直接改成0.16吧，merge后我就release

Yikun · 2021-06-03T10:55:11Z

index.js

-  var topPrefix = 'top_';
-  var categoryPrefix = 'category_';
+  var category_prefix = 'category_';
+  var regexp = /^(-{3,})(\r\n)([\s\S]+?)\r\n\1\r\n?([\s\S]*)/;


这个regexp自己写的吗？靠谱不，看的头大。：）

参考自: https://github.com/hexojs/hexo-front-matter/blob/69516870249e91ba3e77e5b2e395645b3991d97a/lib/front_matter.js#L5

这一段主要是将FrontMatter中的CRLF替换为LF（我的文章中都是CRLF，不知道你的有没有这个问题），不然无法正常解析。如果全文替换，又会影响文章生成，所以最后用了正则。

加个注释吧

或者是不是可以直接引用这个变量，防止发生变化。加个注释和链接也可以，你自己看吧。：）

或者是不是可以直接引用这个变量，防止发生变化。加个注释和链接也可以，你自己看吧。：）

正则稍有不同，hexo-front-matter用的是LF，这里是用CRLF。我注释个链接。

Yikun · 2021-06-03T11:16:38Z

close and reopen to trigger CI, : )

Yikun · 2021-06-03T11:18:13Z

好了，我没啥问题了。可以merge的话我就merge了

CloudyCity · 2021-06-03T12:23:18Z

@Yikun 合并front-matter时的覆盖优先级你更偏向哪一种？

data = Object.assign(meta, data);

data = Object.assign(data, meta);

Yikun · 2021-06-03T12:30:51Z

meta应该可以覆盖掉data的。

当用户指定meta后，可以无视我们的规则（title的对应，label的对应等）。

这个文档补充一下：
If you specify the front-matter in the issue content, like:

---
cover: http://demo.jpeg
top: 1
---
# Title
Hello World!

The front-matter will be transparently added in your post writings. Note that, the front-matter in issue has the highest priority, that means the internal front-matter(such as, title, tags, number, date) will also be replaced.

Yikun · 2021-06-03T12:47:39Z

README.md

- "top_", set the top priority for the post.
 - "draft", the post layout will be set to "draft", that means the post will be stored in draft dir
 - "publish", if user migrate with "--publish" opt, only post with "publish" label will be created.



Front-matter support

If you specify the front-matter in the issue content, like:

--- cover: http://demo.jpeg top: 1 --- # Title Hello World!

The front-matter will be transparently added in your post writings.

Note that, the front-matter in the issue content has the highest priority, that means the internal front-matter which generated by migrator (such as, title, tags, number, date) will also be replaced.

Front-matter作为一个独立的章节写吧

Yikun · 2021-06-03T14:15:38Z

https://www.npmjs.com/package/hexo-migrator-github-issue/v/0.1.6

@CloudyCity 已发布，感谢！

CloudyCity added 2 commits June 2, 2021 18:48

Support front-matter in the issue content

e56f8f1

Remove label support for top_x

93d1794

Yikun reviewed Jun 3, 2021

View reviewed changes

index.js Show resolved Hide resolved

index.js Outdated Show resolved Hide resolved

package.json Show resolved Hide resolved

Fix parse front-matter

251c8b7

CloudyCity closed this Jun 3, 2021

CloudyCity reopened this Jun 3, 2021

Yikun reviewed Jun 3, 2021

View reviewed changes

Yikun closed this Jun 3, 2021

Yikun reopened this Jun 3, 2021

Yikun approved these changes Jun 3, 2021

View reviewed changes

Yikun reviewed Jun 3, 2021

View reviewed changes

Meta overwrite label

de36c2b

Yikun merged commit dc0add2 into Yikun:master Jun 3, 2021

		@@ -4,7 +4,8 @@
		"description": "Github issue migrator plugin for Hexo.",

Support front-matter in the issue content #7

Support front-matter in the issue content #7

Uh oh!

Conversation

CloudyCity commented Jun 2, 2021

Uh oh!

Yikun commented Jun 3, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CloudyCity commented Jun 3, 2021

Uh oh!

Yikun commented Jun 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Yikun Jun 3, 2021

Choose a reason for hiding this comment

Uh oh!

Yikun Jun 3, 2021

Choose a reason for hiding this comment

Uh oh!

CloudyCity Jun 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CloudyCity Jun 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Yikun Jun 3, 2021

Choose a reason for hiding this comment

Uh oh!

Yikun Jun 3, 2021

Choose a reason for hiding this comment

Uh oh!

CloudyCity Jun 3, 2021

Choose a reason for hiding this comment

Uh oh!

Yikun commented Jun 3, 2021

Uh oh!

Yikun commented Jun 3, 2021

Uh oh!

CloudyCity commented Jun 3, 2021

Uh oh!

Yikun commented Jun 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Yikun Jun 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Front-matter support

Uh oh!

Yikun commented Jun 3, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Yikun commented Jun 3, 2021 •

edited

Loading

CloudyCity Jun 3, 2021 •

edited

Loading

CloudyCity Jun 3, 2021 •

edited

Loading

Yikun commented Jun 3, 2021 •

edited

Loading

Yikun Jun 3, 2021 •

edited

Loading