Update to .NET9, add unit tests, rework library loading #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProbablePrime
approved these changes
Sep 24, 2025
Member
|
I'd appreciate a second review from YDMS so picked @jae1911. |
jae1911
approved these changes
Sep 24, 2025
Member
jae1911
left a comment
jae1911
left a comment
There was a problem hiding this comment.
Reviewing the changes and the pipelines in your fork, I think that's good.
Thanks for the PR!
Member
|
Alright we're merging! There may be a short delay before we're able to integrate this into Resonite actual, but the work is now 10x easier than before \o/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR is large in scope, however the amount of actual changes are quite small. If you would like me to create 3 separate PRs each basing off the last for review purposes, I can do so, but I think one PR should be more efficient in this case.
The GDI libraries and examples are untested as I can't compile them but for GDI/Harfbuzz it should be okay as FrooxEngine doesn't use them anyways.
Update to SDK/.NET 9
I've migrated the solution to use SDK-style projects, gutting out unnecessary flags and files to make them tiny. This is the bulk of the number of lines changed (mostly removals).
I've also made the decision to target .NET 9 since I'm working from a Linux host and I found it unnecessary to keep framework compatibility. This isn't complicated code, so I highly doubt there are any relevant breaking changes.
Add unit tests
I've added some simple unit tests, making sure that at minimum, the library is functional, as in it can load and render glyphs. These can be made more robust at a later date, but for simplicity I opted to not add too many just yet.
Rework library loading
I've added a static constructor to the internal FreeType API class to set up a new DLL import resolver. This allows us to load the correct library name on Linux. It will try to load the existing
freetype6.so/dllfirst, then try to loadlibfreetype.so.6.This makes it so the system library is a fallback; it will try to load
freetype6.sofirst, then try the system library. This makes it so if the user was already able to loadfreetype6, there are no changes. If not, they will use the system version which closes #1.There's also a path for Mac but I don't have natives for Mac.
Tested Platforms