добавляю первое задание второй части диплома #635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def bun(): | ||
| """Фикстура для создания булочки""" | ||
| from bun import Bun | ||
| return Bun("Краторная булочка", 100.0) |
There was a problem hiding this comment.
Можно лучше здесь и далее: лучше выносить тестовые данные во внешний модуль (например, data). Это позволит облегчить их поддержку
Comment on lines
+13
to
+33
| @pytest.fixture | ||
| def burger(): | ||
| """Создает новый бургер для каждого теста""" | ||
| return Burger() | ||
|
|
||
| @pytest.fixture | ||
| def mock_bun(): | ||
| """Создает мок булочки""" | ||
| mock = Mock() | ||
| mock.get_price.return_value = 100 | ||
| mock.get_name.return_value = "test bun" | ||
| return mock | ||
|
|
||
| @pytest.fixture | ||
| def mock_ingredient(): | ||
| """Создает мок ингредиента""" | ||
| mock = Mock() | ||
| mock.get_price.return_value = 50 | ||
| mock.get_name.return_value = "test ingredient" | ||
| mock.get_type.return_value = INGREDIENT_TYPE_SAUCE | ||
| return mock |
There was a problem hiding this comment.
Необходимо исправить здесь и далее: фикстуры стоит вынести к остальным в модуль conftest
There was a problem hiding this comment.
А тут фикстуры все еще в теле теста, дублируют те что уже есть в conftest. От этих можно избавиться
tests/test_burger.py
Outdated
Comment on lines
88
to
90
| assert "test bun" in receipt | ||
| assert "test sauce" in receipt | ||
| assert "Price: 250" in receipt # 2*100 + 50 No newline at end of file |
There was a problem hiding this comment.
Нужно исправить: проверка через in в данном кейсе не будет надёжной, необходимо проверить полное соответствие вывода от get_receipt
Comment on lines
28
to
30
| assert ingredient.get_type() == INGREDIENT_TYPE_SAUCE | ||
| assert ingredient.get_name() == "hot sauce" | ||
| assert ingredient.get_price() == 100.0 |
There was a problem hiding this comment.
Нужно исправить: стоит разделить эти тесты, юнит-тесты должны быть максимально атомарными
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавил юнит-тесты с 100% покрытием: