add new changes #633
Open
add new changes #633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irisqul
reviewed
Nov 24, 2025
irisqul
left a comment
irisqul
left a comment
There was a problem hiding this comment.
✅ Сильные стороны:
- Код запускается без ошибок
- Тестовая архитектура соответствует изученным практикам написания автотестов
- Обеспечено необходимое тестовое покрытие
| db = Database() | ||
| ingredients = db.available_ingredients() | ||
| assert len(ingredients) == 6 | ||
| assert isinstance(ingredients[0], Ingredient) |
There was a problem hiding this comment.
Можно лучше: мы тестируем не атрибуты экземпляров класса или наполнение базы данных, а методы приложения. Необходимо добавить шаги в которых будут использованы методы и проверить результат. Базу данных тестировать юниттестами не получится
| bun.get_price.return_value = 60 | ||
| burger.set_buns(bun) | ||
|
|
||
| ingredient = Mock() |
There was a problem hiding this comment.
Отлично: благодаря мокам тесты стали быстрее и управляемее, теперь они меньше зависят от внешних данных
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.