Develop1 #631
Open
Develop1 #631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/test_burger.py
Outdated
| # - test_set_buns_sets_bun: проверяет базовый сценарий первого вызова метода. | ||
| # - test_set_buns_uses_latest_bun: проверяет сценарий повторного вызова метода(обновление состояния) | ||
|
|
||
| def test_set_buns_sets_bun(burger): |
There was a problem hiding this comment.
Нужно исправить здесь и далее: Для корректного запуска тестов необходимо код с шагами теста поместить в тестовый метод (нейминг начинается с test_), а метод - в тестовый класс (нейминг начинается с Test). Необходимо привести к такому формату все модули внутри пакета tests
tests/test_burger.py
Outdated
Comment on lines
145
to
150
| assert lines[0] == "(==== black bun ====)" | ||
| assert lines[1] == "= sauce hot sauce =" | ||
| assert lines[2] == "(==== black bun ====)" | ||
| assert lines[3] == "" # пустая строка | ||
| assert lines[4].startswith("Price: ") # цена начинается с Price | ||
|
|
There was a problem hiding this comment.
Необходимо исправить: стоит сравнивать весь вывод от get_receipt целиком, а не построчно
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Краткое резюме проделанной работы (с указанием классов)
Создана фикстура burger в conftest.py, предоставляющая новый экземпляр класса Burger.
Протестированы все методы класса Burger:
set_buns
add_ingredient
remove_ingredient
move_ingredient
get_price
get_receipt