refactor: Migrate library and demo to androidx library + code cleanup#15
Open
RofaeilGerges wants to merge 2 commits intoYalantis:masterfrom
Open
refactor: Migrate library and demo to androidx library + code cleanup#15RofaeilGerges wants to merge 2 commits intoYalantis:masterfrom
RofaeilGerges wants to merge 2 commits intoYalantis:masterfrom
Conversation
added 2 commits
June 14, 2020 23:30
* Migrated library module and demo module to use androidx and refactor the existing layouts and classes to use androidx. * Pumped compileSdkVersion and targetSdkVersion to 29, buildToolsVersion to 29.0.3. * Pumped gradle-wrapper to 6.4.1, gradle plugin to 4.0.0 and fabric plugin to 1.28.0 + adding the org.gradle.parallel=true property for faster build time. * Removed the butterknife dependency from demo module because it's now deprecated and causes runtime crashes without any obvious reasons and replaced the current code with a simple call to findViewById(). * Returned PixelFormat.UNKNOWN from getOpacity() instead of 0, the raw value of this constant to avoid the error warning in android studio. * Removed *.iml files from project to avoid project configurations issues on different computers when opening the project (which they should have been ignored in .gitignore file in the first place).
Removed Timber library from the library module because: 1. it's causing crash on android 7.1 with this crash stacktrace java.lang.NoClassDefFoundError: Failed resolution of: Timber/log/Timber. 2. the library should not include a logging library dependency in order to be a light weight library with minimum size effect on the app size that include it as possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated library module and demo module to use androidx and refactor
the existing layouts and classes to use androidx.
Pumped compileSdkVersion and targetSdkVersion to 29, buildToolsVersion
to 29.0.3.
Pumped gradle-wrapper to 6.4.1, gradle plugin to 4.0.0 and fabric
plugin to 1.28.0 + adding the org.gradle.parallel=true property for
faster build time.
Removed the butterknife dependency from demo module because it's now
deprecated and causes runtime crashes without any obvious reasons and
replaced the current code with a simple call to findViewById().
Returned PixelFormat.UNKNOWN from getOpacity() instead of 0, the raw
value of this constant to avoid the error warning in android studio.
Removed *.iml files from the project to avoid project configurations
issues on different computers when opening the project (which they
should have been ignored in .gitignore file in the first place).
Removed Timber library from the library module because:
java.lang.NoClassDefFoundError: Failed resolution of: Timber/log/Timber.
to be a light weight library with minimum size effect on the app size
that include it as possible.