Telegram storage with gotd in redis only: Bot State, Channel Access Hash, Channel Pts, User Access Hash. Telegram Client Create with gotd: SOCKS5, MTProto, Background Connect, Bot Authorization, Run Updates Manager
#7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements a Redis-backed Telegram storage solution using gotd for managing bot state, channel access hashes, and channel pts. The implementation provides a comprehensive persistence layer for Telegram updates and state management.
- Adds a thread-safe set implementation (
yathreadsafeset) with concurrent operations support - Implements Redis-based Telegram storage (
yatgstorage) for bot state, channel pts, and access hashes - Provides Telegram client utilities (
yatgclient) with proxy support and background connection handling
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| yathreadsafeset/yathreadsafeset.go | Thread-safe generic set implementation with mutex-protected operations |
| yathreadsafeset/yathreadsafeset_test.go | Comprehensive test suite for thread-safe set operations |
| yathreadsafeset/utils.go | Safety check utility for set initialization |
| yatgstorage/yatgstorage.go | Redis-backed storage for Telegram bot state and access hashes |
| yatgstorage/yatgstorage_test.go | Tests for storage operations and workflow validation |
| yatgstorage/errors.go | Error definitions for storage operations |
| yatgclient/yatgclient.go | Telegram client wrapper with proxy support |
| yatgclient/yatgclient_test.go | Tests for proxy parsing and client functionality |
| go.mod | Dependency updates for gotd and related packages |
| .golangci.yml | Added golines formatter |
Comment on lines
+121
to
+122
| // DEADLOCK: During iteration, it is forbidden to modify the set (add or remove values), | ||
| // failing to do so will result in a deadlock. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Comment on lines
+337
to
+348
| other.mu.RLock() | ||
|
|
||
| intersection := NewThreadSafeSet[K]() | ||
|
|
||
| for k := range m.data { | ||
| if other.Has(k) { | ||
| intersection.Set(k) | ||
| } | ||
| } | ||
|
|
||
| m.mu.RUnlock() | ||
| other.mu.RUnlock() |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Comment on lines
+405
to
+413
| other.mu.RLock() | ||
|
|
||
| for k := range m.data { | ||
| if !other.Has(k) { | ||
| return false | ||
| } | ||
| } | ||
|
|
||
| m.mu.RUnlock() |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Comment on lines
+468
to
+479
| m.mu.RLock() | ||
| other.mu.RLock() | ||
|
|
||
| for k := range m.data { | ||
| if !other.Has(k) { | ||
| result.Set(k) | ||
| } | ||
| } | ||
|
|
||
| m.mu.RUnlock() | ||
| other.mu.RUnlock() | ||
|
|
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Comment on lines
+500
to
+516
| other.mu.RLock() | ||
|
|
||
| for k := range m.data { | ||
| if !other.Has(k) { | ||
| result.Set(k) | ||
| } | ||
| } | ||
|
|
||
| for k := range other.data { | ||
| if !m.Has(k) { | ||
| result.Set(k) | ||
| } | ||
| } | ||
|
|
||
| m.mu.RUnlock() | ||
| other.mu.RUnlock() | ||
|
|
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
brizzinck
changed the title
gotd in redis only: Bot State, Channel Access Hash, Channel Ptsgotd in redis only: Bot State, Channel Access Hash, Channel Pts, User Access Hash. Telegram Client Create with gotd: SOCKS5, MTProto, Background Connect, Bot Authorization, Run Updates Manager
YaCodesDevelopment
requested changes
Jul 27, 2025
Member
YaCodesDevelopment
left a comment
YaCodesDevelopment
left a comment
There was a problem hiding this comment.
"Have set" is not a valid form, replace it everywhere with something adequate
YaCodesDevelopment
approved these changes
Jul 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.