Skip to content

Conversation

@brizzinck
Copy link
Member

No description provided.

@brizzinck brizzinck self-assigned this Jun 22, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces an exponential backoff mechanic with a new Exponential backoff implementation and comprehensive tests.

  • Adds an Exponential backoff strategy in exponential.go
  • Implements tests in yabackoff_test.go to verify behavior for next interval, reset, maximum interval, and sleep functionality
  • Updates the module dependencies in go.mod to include testify for testing

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

File Description
yabackoff/yabackoff_test.go Added tests for the exponential backoff mechanism
yabackoff/yabackoff.go Provided the Backoff interface and default constants
yabackoff/exponential.go Implemented the Exponential backoff strategy
go.mod Included testify dependency for testing
Comments suppressed due to low confidence (2)

yabackoff/yabackoff_test.go:38

  • The helper function 'min' is used but not defined in this file, which might cause a compilation error. Consider defining or importing a min function.
		next := min(time.Duration(float64(last)*multiplier), maxInterval)

yabackoff/exponential.go:100

  • The helper function 'min' is used but not defined, potentially causing a compilation error. Consider defining or importing an appropriate min function.
		e.currentInterval = min(time.Duration(float64(e.currentInterval)*e.multiplier), e.maxInterval)

@YaCodesDevelopment YaCodesDevelopment merged commit 507b1fc into main Jun 22, 2025
1 check passed
@YaCodesDevelopment YaCodesDevelopment deleted the features/backoff branch June 22, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants