Skip to content

Conversation

@brizzinck
Copy link
Member

No description provided.

@brizzinck brizzinck self-assigned this Jun 22, 2025
@brizzinck brizzinck requested a review from Copilot June 22, 2025 14:43

This comment was marked as outdated.

@YaCodeDev YaCodeDev deleted a comment from Copilot AI Jun 22, 2025
@brizzinck brizzinck marked this pull request as draft June 22, 2025 14:51
@brizzinck brizzinck requested a review from Copilot June 22, 2025 15:16

This comment was marked as outdated.

@brizzinck brizzinck marked this pull request as ready for review June 22, 2025 16:10

This comment was marked as outdated.

Copy link
Member

@YaCodesDevelopment YaCodesDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make use of Error constants

@brizzinck brizzinck requested a review from Copilot June 22, 2025 20:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a generic caching abstraction with pluggable back‑ends, supporting both Redis and in‑memory caching implementations. Key changes include the implementation of the Cache interface and its methods, dedicated Redis and memory back‑end services, and comprehensive tests to verify cache functionality.

Reviewed Changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
yacache/yacache_test.go Test cases for checking cache initialization for Redis and Memory
yacache/yacache.go Defines the generic Cache interface and NewCache constructor
yacache/redis_test.go Unit tests for Redis-based cache operations
yacache/redis.go Redis-backed cache implementation wrapping *redis.Client
yacache/memory_test.go Unit tests for Memory-based cache operations
yacache/errors.go Custom error definitions used throughout cache operations
go.mod Module dependency updates, including test and Redis packages
Comments suppressed due to low confidence (2)

yacache/redis_test.go:42

  • The identifiers 'yamainKey', 'yachildKey', and 'yavalue' appear to be undefined in this file. Consider defining or importing these constants to avoid compilation errors.
	redis.Raw().HSet(ctx, yamainKey, yachildKey, yavalue)

yacache/errors.go:9

  • Spelling mistake in the error message: 'faildet' should be corrected to 'failed'.
	ErrFailedToGetDeleteSingle = errors.New("[CACHE] faildet to get and delete value")

@YaCodesDevelopment YaCodesDevelopment merged commit 2e781ce into main Jun 22, 2025
1 check passed
@YaCodesDevelopment YaCodesDevelopment deleted the features/cache branch June 22, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants