-
Notifications
You must be signed in to change notification settings - Fork 0
New cache services: [REDIS], [MEMORY] #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
YaCodesDevelopment
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make use of Error constants
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a generic caching abstraction with pluggable back‑ends, supporting both Redis and in‑memory caching implementations. Key changes include the implementation of the Cache interface and its methods, dedicated Redis and memory back‑end services, and comprehensive tests to verify cache functionality.
Reviewed Changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| yacache/yacache_test.go | Test cases for checking cache initialization for Redis and Memory |
| yacache/yacache.go | Defines the generic Cache interface and NewCache constructor |
| yacache/redis_test.go | Unit tests for Redis-based cache operations |
| yacache/redis.go | Redis-backed cache implementation wrapping *redis.Client |
| yacache/memory_test.go | Unit tests for Memory-based cache operations |
| yacache/errors.go | Custom error definitions used throughout cache operations |
| go.mod | Module dependency updates, including test and Redis packages |
Comments suppressed due to low confidence (2)
yacache/redis_test.go:42
- The identifiers 'yamainKey', 'yachildKey', and 'yavalue' appear to be undefined in this file. Consider defining or importing these constants to avoid compilation errors.
redis.Raw().HSet(ctx, yamainKey, yachildKey, yavalue)
yacache/errors.go:9
- Spelling mistake in the error message: 'faildet' should be corrected to 'failed'.
ErrFailedToGetDeleteSingle = errors.New("[CACHE] faildet to get and delete value")
No description provided.