Skip to content

extracted logic for activity completion#113

Open
yubrandon wants to merge 4 commits intomainfrom
activity-features
Open

extracted logic for activity completion#113
yubrandon wants to merge 4 commits intomainfrom
activity-features

Conversation

@yubrandon
Copy link
Collaborator

Isolated the logic for reusability

@DeMentidDev
Copy link
Collaborator

DeMentidDev commented Feb 6, 2026

While I am unsure how I should be testing your logic, the website runs without errors. While everything is looking good so far, I won't be able to reliably merge your changes until I know how to test your logic.

(If the pull request isn't ready for a full review yet, then disregard this comment)

@yubrandon
Copy link
Collaborator Author

Most of the changes are in the backend, so I had to set static arguments for testing the requests made through completeActivity and manually check the database in order to test my changes.

I think that we would need to create a mock db to automate tests for this PR as well as other middleware implementations, but I am not familiar with how we would handle the methods being used since they were written for MongoDB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants