Open
Conversation
Collaborator
|
While I am unsure how I should be testing your logic, the website runs without errors. While everything is looking good so far, I won't be able to reliably merge your changes until I know how to test your logic. (If the pull request isn't ready for a full review yet, then disregard this comment) |
Collaborator
Author
|
Most of the changes are in the backend, so I had to set static arguments for testing the requests made through completeActivity and manually check the database in order to test my changes. I think that we would need to create a mock db to automate tests for this PR as well as other middleware implementations, but I am not familiar with how we would handle the methods being used since they were written for MongoDB. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Isolated the logic for reusability