feat: Add manual File closing capability#142
Open
andreascasapu wants to merge 1 commit intoXuanwo:mainfrom
Open
feat: Add manual File closing capability#142andreascasapu wants to merge 1 commit intoXuanwo:mainfrom
andreascasapu wants to merge 1 commit intoXuanwo:mainfrom
Conversation
This was referenced Jan 8, 2026
andreascasapu
force-pushed
the
#141-add-manual-file-closing-mechanism-for-error-handling
branch
from
9e3bcbd to
0fff170
Compare
A try_close() method is added to File in order to allow users to manually close the file and handle any resulting errors. In the process, make Drop impl defensive around the file having already been closed due to the addition of try_close.
andreascasapu
force-pushed
the
#141-add-manual-file-closing-mechanism-for-error-handling
branch
from
0fff170 to
d7a3c3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A try_close() method is added to File in order to allow users to manually close the file and handle any resulting errors.