Open
Conversation
Author
|
I have no idea about the CI failure, should I add the attribute or specify a toolchain in |
Owner
|
Hi, @Lablace. Thanks a lot for working on this. I believe the issue lies within the codebase itself, which refers to invalid features. We can remove that dead code if it's not needed. Would you like to submit a PR for that? |
Author
|
I see that, those codes are in the test file but that's not what I have worked on. I just removed them, please help to check whether that's OK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to set some configs (client domain only) which are described in this official table. It will also override the ones specified in
hdfs-site.xml, which is really useful if directly modifying that file is not possible or not that favorable.