Skip to content

feat: Set config strings#134

Open
Lablace wants to merge 2 commits intoXuanwo:mainfrom
Lablace:main
Open

feat: Set config strings#134
Lablace wants to merge 2 commits intoXuanwo:mainfrom
Lablace:main

Conversation

@Lablace
Copy link

@Lablace Lablace commented Sep 23, 2024

This adds the ability to set some configs (client domain only) which are described in this official table. It will also override the ones specified in hdfs-site.xml, which is really useful if directly modifying that file is not possible or not that favorable.

@Lablace
Copy link
Author

Lablace commented Sep 23, 2024

I have no idea about the CI failure, should I add the attribute or specify a toolchain in rust-toolchain.toml?

@Xuanwo
Copy link
Owner

Xuanwo commented Sep 23, 2024

Hi, @Lablace. Thanks a lot for working on this. I believe the issue lies within the codebase itself, which refers to invalid features. We can remove that dead code if it's not needed. Would you like to submit a PR for that?

@Lablace
Copy link
Author

Lablace commented Sep 24, 2024

I see that, those codes are in the test file but that's not what I have worked on. I just removed them, please help to check whether that's OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments