Skip to content

Fix widget localStorage handling #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
XperfectTR wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix widget localStorage handling #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions js/base.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ $('.open-widget').live('click',function(){

function openWidget(widget, widgetIdentifier, speed){

// decrement closed-widget-count
// decrement closed-widget-count
if(widget.is(":hidden")) {
closedWidgetCount.text( Number(closedWidgetCount.text()) - 1);
}
Expand All @@ -158,9 +158,9 @@ function openWidget(widget, widgetIdentifier, speed){
widget.show(500);

// remove widget from localstorage
var localData = JSON.parse(window.localStorage.getItem('hidden'));
var localData = JSON.parse(window.localStorage.getItem('hidden')) || [];
for(var i = localData.length; i--;){
if (localData[i] == widgetIdentifier) {
if (localData[i] === widgetIdentifier) {
localData.splice(i, 1);
}
}
Expand All @@ -171,7 +171,7 @@ function openWidget(widget, widgetIdentifier, speed){
function hideWidget(widget, speed){
// cache DOM objects/data used in this function
var widgetName = widget.find('.widget-header h3').text();
var widgetIdentifier = widget.attr('id');
var widgetIdentifier = widget.attr('id');

// update count
if(!widget.is(":hidden")) {
Expand All @@ -187,16 +187,12 @@ function hideWidget(widget, speed){
// add widget to localstorage (and create item if needed)
var localData = JSON.parse(window.localStorage.getItem('hidden'));
if(localData == null) {
hidden = new Array();
hidden.push(widgetIdentifier);
localStorage.setItem('hidden', JSON.stringify(hidden));
localData = [widgetIdentifier];
}
else{
if (!isInArray(localData, widgetIdentifier)) {
localData.push(widgetIdentifier);
localStorage.setItem('hidden', JSON.stringify(localData));
}
else if (!isInArray(localData, widgetIdentifier)) {
localData.push(widgetIdentifier);
}
localStorage.setItem('hidden', JSON.stringify(localData));
}

function keepWidgetHidden(){
Expand Down