RW-105: Added redirect for different roles#128
Open
Krupshark wants to merge 1 commit intoXaoGao:developfrom
Open
RW-105: Added redirect for different roles#128Krupshark wants to merge 1 commit intoXaoGao:developfrom
Krupshark wants to merge 1 commit intoXaoGao:developfrom
Conversation
XaoGao
requested changes
Dec 20, 2023
Owner
XaoGao
left a comment
XaoGao
left a comment
There was a problem hiding this comment.
@Krupshark в целом все хорошо, но нужны так же тесты
| @@ -1,3 +1,13 @@ | |||
| class PagesController < ApplicationController | |||
| def welcome; end | |||
| def welcome | |||
Owner
There was a problem hiding this comment.
Теперь нужно будет написать тест на этот метод
| private | ||
|
|
||
| def page_for_signed_in(user) | ||
| {user.applicant? => vacancies_path, user.company? => resumes_path}[true] |
| ul.navbar-nav.me-auto.mb-2.mb-lg-0 | ||
| li.nav-item | ||
| = link_to "Home", root_path, class: "nav-link fs-4 text-black" | ||
| = link_to "Home", home_link, class: "nav-link fs-4 text-black" |
Owner
There was a problem hiding this comment.
Ты проверил локально, что будет если user не зашел в аккаунт и нажал на кнопку ?
| end | ||
| end | ||
|
|
||
| def home_link |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@XaoGao, complite, check PR