(feat) Add Embla carousel #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview environment URLdotnet |
Preview environment URLdotnet |
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the custom team carousel with the Embla Carousel library, simplifying slide logic and enriching interactivity and accessibility.
- Swapped out manual slide grouping for Embla’s viewport/container slide setup.
- Updated CSS to use Embla BEM class names and maintain responsive layouts.
- Added Embla initialization script with loop, autoplay, buttons, and event handlers.
- Included
embla-carouselas a new dependency.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| libs/ui/src/TeamCarousel.astro | Integrate Embla Carousel: markup, styles, and script |
| libs/ui/package.json | Add embla-carousel dependency |
Comments suppressed due to low confidence (1)
libs/ui/src/TeamCarousel.astro:203
- There’s no automated coverage for the
initEmblaCarousellogic; consider adding unit or integration tests to verify initialization, button state updates, and autoplay behavior.
const initEmblaCarousel = () => {
goozdev
force-pushed
the
feature/updateteamcarousel
branch
from
5529d8f to
559b472
Compare
Preview environment URLdotnet |
Preview environment URLdotnet |
jlieuw
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Embla Carousel instead of our own custom implementation.
#136