Skip to content

797: Default range question type to start at 0 #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Zachary-Sutherby wants to merge 1 commit into
base: master
Choose a base branch
from
Open

797: Default range question type to start at 0 #803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyxform/xls2json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ def process_range_question_type(
parameters=parameters, allowed=("start", "end", "step")
)
parameters_map = {"start": "start", "end": "end", "step": "step"}
defaults = {"start": "1", "end": "10", "step": "1"}
defaults = {"start": "0", "end": "10", "step": "1"}

# set defaults
for key in parameters_map.values():
Expand Down
6 changes: 3 additions & 3 deletions tests/test_range.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def test_range_type_defaults(self):
""",
xml__contains=[
'<bind nodeset="/data/level" type="int"/>',
'<range end="10" ref="/data/level" start="1" step="1">',
'<range end="10" ref="/data/level" start="0" step="1">',
],
)

Expand All @@ -58,7 +58,7 @@ def test_range_type_defaults(self):
""",
xml__contains=[
'<bind nodeset="/data/level" type="int"/>',
'<range end="20" ref="/data/level" start="1" step="1">',
'<range end="20" ref="/data/level" start="0" step="1">',
],
)

Expand All @@ -71,7 +71,7 @@ def test_range_type_defaults(self):
""",
xml__contains=[
'<bind nodeset="/data/level" type="int"/>',
'<range end="10" ref="/data/level" start="1" step="1">',
'<range end="10" ref="/data/level" start="0" step="1">',
],
)

Expand Down