Trigger an Event in XComUnitPawn.PlayHitEffects#826
Trigger an Event in XComUnitPawn.PlayHitEffects#826Musashi1584 merged 3 commits intoX2CommunityCore:masterfrom
Conversation
Co-Authored-By: Xymanek <xymanek@outlook.com>
Musashi1584
added
ready-for-merge
| /// EventID: OverrideHitEffects | ||
| /// EventData: XComLWTuple { | ||
| /// Data: [ | ||
| /// out bool OverrideHitEffect, |
There was a problem hiding this comment.
You should clarify in the body of the docs above what impact this value has (so modders don't need to look into the source code to find out). I know it can be inferred, but I can only be confident in the inference because I looked at the code.
A more subtle question is whether changing the event values below affects PlayHitEffects() even if OverrideHitEffect is false. One might assume the values are ignored in that case, but it is still an assumption.
There was a problem hiding this comment.
@pledbrook is that more clear now with that addition?
/// If OverrideHitEffect is set to true the PlayHitEffects function will return early and the default behavior is ommited.
pledbrook
left a comment
pledbrook
left a comment
There was a problem hiding this comment.
I'll leave it up to you whether you want to change the terminology for "omitted".
3 participants
Implements Issue #825