Implemented scripted versions for ability target styles#762
Closed
Xymanek wants to merge 1 commit intoX2CommunityCore:masterfrom
Closed
Implemented scripted versions for ability target styles#762Xymanek wants to merge 1 commit intoX2CommunityCore:masterfrom
Xymanek wants to merge 1 commit intoX2CommunityCore:masterfrom
Conversation
Member
Author
|
Needs tracking issue and docs, @Iridar? |
robojumper
requested changes
Feb 7, 2020
Member
There was a problem hiding this comment.
The addition of the _Scripted classes is unnecessarily complicated. We control all native classes, so creating a hardcoded list of native target styles is viable. This would make the solution more "plug-and-play" and would also allow people to subclass existing native target styles, potentially calling the super functions or patching existing target styles from foreign templates using the new-with-template syntax.
P.S.: I don't suppose there's a way to easily find out whether a class is native? THERE IS: #764
This was referenced Feb 7, 2020
Member
Author
|
Currently waiting for #764 to be merged |
Contributor
|
#764 has been merged |
Member
|
Closing in favor of #918. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Based on discord suggestion by @robojumper, only affects abilities that use a scripted style(s)
Demo: Xymanek@36c5b96
cc @Iridar (I did this to prove you wrong
), @pledbrook (I know LW2 needed this)