Conversation
PO provided new input docs
This might be put back in place later, but with new layouts it makes less sense to have a page break before a new chapter.
The parsing isn't quite right, it will come back corrected in a future update.
We already remove Links: section, but some languages localize the word.
This is a big commit. The primary deliverable for this commit is adding versification at the book and chapter chunk level for PDF, ePub, and Docx, their supporting front and backend tests, and new layouts that match the document prototype provided by the PO as a guide. This commit also makes TW words linking work properly. This commit also adds new optional settings that the user may select which are contextually relevant for the given assembly strategy (interleaving strategy chosen). These can be seen dynamically changing on the final settings page of the UI depending on what is chosen. Many bug fixes and visual enhancements to layout along the way. More to be done, but this should be a radically useful upgrade for TS.
PurpleGuitar
approved these changes
Nov 24, 2025
| "tn-condensed": "Condensed Translation Notes", | ||
| "tq": "Translation Questions", | ||
| "tw": "Translation Words", | ||
| # "udb": "Unlocked Dynamic Bible", # Content team doesn't want udb used TODO (just for English or ?) |
Contributor
There was a problem hiding this comment.
I believe English is the only language that has a UDB resource.
| .union(bc_book.lang_code for bc_book in bc_books) | ||
| .union(rg_book.lang_code for rg_book in rg_books) | ||
| # Collect and duplicate max number of lang_codes | ||
| lang_codes = list( |
Contributor
There was a problem hiding this comment.
This is a clever way of emulating a set that keeps the order of its items.
| ("pt-br", "1 Corintios"): "1 Coríntios", | ||
| ( | ||
| "rmp", | ||
| "Galasians sapta 1. v/1 da-h pol. dal goad phi da-h dululan, ne dal mai-h phi da-h apostel ipais ag mayaib. phi. je-su krais mai-h mam gad pha, nug krais matmat ag mau sen pha, nug da-h ipais ag malan. v/2 da-h ayaid amayaid da-h pha dade, hit jain hen ohvu iu- an sios galesia e-h hagaug. v/3 gad mam hita, hayaug je-su krais pha, nug-te hagaug he-eh phadu ne mab hogad nauha-h da-h-du. v/4", |
Contributor
There was a problem hiding this comment.
Is this correction still needed? I was under the impression that MaryEllen fixed this issue in the source.
github-project-automation
bot
moved this from In progress
to Done
in DOC Project Management
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New strategies, layouts, linking, and context aware options
This is a big commit. The primary deliverable for this commit is
adding versification at the book and chapter chunk level for PDF,
ePub, and Docx, their supporting front and backend tests, and new
layouts that match the document prototype provided by the PO as a
guide.
This commit also makes TW words linking work properly.
This commit also adds new optional settings that the user may select
which are contextually relevant for the given assembly
strategy (interleaving strategy chosen). These can be seen dynamically
changing on the final settings page of the UI depending on what is
chosen.
Many bug fixes and visual enhancements to layout along the way.
More to be done, but this should be a very useful upgrade for TS.
This PR temporarily retires OT Survey Reviewer's Guide feature for Passages app. It will be re-released later after some fixes.