🎨 Palette: Enhance table sorting accessibility and fix semantic bug#39
🎨 Palette: Enhance table sorting accessibility and fix semantic bug#39
Conversation
- Fixed mismatched `</button>` tag in `base.html` for `quickScanTrigger`. - Enhanced table sorting in `list_base.html` by adding keyboard support (`role="button"`, `tabindex="0"`, `Enter`/`Space` listeners). - Improved screen reader support with `aria-sort` and descriptive `aria-label` attributes for sorting headers. - Added focus styles for keyboard users. - Updated Palette's journal with accessibility learnings. Co-authored-by: Woschj <81321922+Woschj@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎨 Palette: One Micro-UX Improvement
💡 What:
base.htmlwhere thequickScanTrigger(adiv) had a mismatched closing</button>tag.list_base.htmlto be fully accessible. It now supports keyboard interaction (Tab to header, Enter/Space to sort) and provides screen reader feedback viaaria-sortand descriptivearia-labelattributes.🎯 Why:
base.htmlcorrupted the accessibility tree and made the sidebar navigation confusing for screen readers.♿ Accessibility:
role="button"andtabindex="0"to header wrappers.onkeydownforEnterandSpace.aria-sort(ascending/descending) onthelements.aria-label(e.g., "Sortieren nach Name").Total change: ~35 lines of template and JS code. Verified with Playwright screenshot tests.
PR created automatically by Jules for task 9248724336508078721 started by @Woschj