Skip to content

WADMIN-9939 Make enum type checks less restrictive #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
btr-rmconsole-2 merged 2 commits into from
Oct 8, 2025
Merged

WADMIN-9939 Make enum type checks less restrictive #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79262d7
Unique != not-empty
tristanduyvejonck-wk Oct 7, 2025
9b4b8ca
Enums can be empty
tristanduyvejonck-wk Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/src/json_schema/utils/type_validators.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class TypeValidators {

static List uniqueList(String key, dynamic value) {
int i = 0;
final List enumValues = TypeValidators.nonEmptyList(key, value);
final List enumValues = TypeValidators.list(key, value);
for (final _ in enumValues) {
for (int j = i + 1; j < enumValues.length; j++) {
if (DeepCollectionEquality().equals(enumValues[i], enumValues[j])) {
Expand Down
4 changes: 0 additions & 4 deletions test/custom/invalid_schemas/draft4/enum.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,6 @@
"description" : "enum: must be an array - not object",
"schema" : { "enum" : {} }
},
{
"description" : "enum: must be a non-empty array",
"schema" : { "enum" : [] }
},
{
"description" : "enum: elements must be unique",
"schema" : { "enum" : [3,4,3] }
Expand Down