feat: add 'idn-email' format validation#204
Open
MichaelDark wants to merge 3 commits intoWorkiva:masterfrom
Open
feat: add 'idn-email' format validation#204MichaelDark wants to merge 3 commits intoWorkiva:masterfrom
MichaelDark wants to merge 3 commits intoWorkiva:masterfrom
Conversation
michaelcarter-wf
suggested changes
Feb 28, 2025
pubspec.yaml
Outdated
| @@ -1,5 +1,5 @@ | |||
| name: json_schema | |||
| version: 5.2.0 | |||
| version: 5.2.1 | |||
There was a problem hiding this comment.
Please revert this change, our automatic versioning system will handle it after the PR is merged.
Author
There was a problem hiding this comment.
@michaelcarter-wf Addressed, version bump and changelog file reverted 👍🏻
| ValidationContext defaultIdnEmailValidator(ValidationContext context, String instanceData) { | ||
| // No maintained dart packages exist to validate RFC6531, | ||
| // and it's too complex for a regex, so best effort is to pass for now. | ||
| if (rfc_6531.regExp.firstMatch(instanceData) == null) { |
There was a problem hiding this comment.
Since we validate this format by default on the default schema version draft7, this is a breaking behavioral change. No need to handle this in your PR, but FYI we'll cut this as 6.0.0
Author
|
@michaelcarter-wf All comments addressed, waiting for the review 👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ultimate problem:
Lack of built-in 'idn-email' format validation.
How it was fixed:
It was fixed using
rfc_6531package.Testing suggestions:
Testing is built-in into
rfc_6531package.Potential areas of regression:
N/A.