Open
Conversation
|
Hello @AvoMandjian and thanks for your PR! While I like the idea of allowing users to customize their error messages, we've also tried to adhere pretty strictly to features described in the JSON Schema specification. Your PR would add a custom keyword that is not listed in the spec, and therefore I don't believe we can accept it as-is. A couple options for you going forward.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ultimate problem:
It did not provide an easy way to customize error messages for specific validation errors. This limitation made it difficult for developers to deliver user-friendly error messages when validating JSON against a schema.
How it was fixed:
added a customMessage property to allow developers to specify custom error messages for specific validation errors in the schema.
Testing suggestions:
Potential areas of regression: