Skip to content

Bugfix/split-group-char #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Courela wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Bugfix/split-group-char #313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
26b1e47
Merge pull request #4 from WorkMaze/master
Courela Dec 31, 2023
66c4f5a
Use Context.SplitGroupChar instead of hardcoded ':'
Courela Jul 11, 2025
0507761
Test 'RedefineSplitGroupCharWithDates'
Courela Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions JUST.net/Utilities.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ public static JArray GroupArrayMultipleProperties<T>(JArray array, string[] grou
if (key == string.Empty)
key += valueOfToken;
else
key += ":" + valueOfToken;
key += $"{context.SplitGroupChar}{valueOfToken}";
}


Expand Down Expand Up @@ -175,7 +175,7 @@ public static JArray GroupArrayMultipleProperties<T>(JArray array, string[] grou

JObject groupObj = new JObject();

string[] keys = pair.Key.Split(':');
string[] keys = pair.Key.Split(context.SplitGroupChar);

int i = 0;
foreach (string groupPropertyName in groupingPropertyNames)
Expand Down
12 changes: 12 additions & 0 deletions UnitTests/Arrays/GroupFunctionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,5 +38,17 @@ public void RedefineSplitChar()

Assert.AreEqual("{\"Result\":[{\"type:a\":\"air\",\"company\":\"Boeing\",\"all\":[{\"name\":\"airplane\"},{\"name\":\"Chopper\"}]},{\"type:a\":\"air\",\"company\":\"Concorde\",\"all\":[{\"name\":\"airplane\"}]},{\"type:a\":\"land\",\"company\":\"GM\",\"all\":[{\"name\":\"car\"},{\"name\":\"truck\"}]},{\"type:a\":\"sea\",\"company\":\"Viking\",\"all\":[{\"name\":\"ship\"}]}]}", result);
}

[Test]
public void RedefineSplitCharWithDates()
{
const string transformer = "{ \"Result\": \"#grouparrayby($,payrollUnit|fromDate,all)\" }";
const string input = "[ { \"payrollUnit\": \"euro\", \"name\": \"John\", \"fromDate\": \"2022-01-01T00:00:00\" }, { \"payrollUnit\": \"euro\", \"name\": \"Smith\", \"fromDate\": \"2022-01-01T00:00:00\" }, { \"payrollUnit\": \"usd\", \"name\": \"Lucy\", \"fromDate\": \"2022-01-01T00:00:00\" }, { \"payrollUnit\": \"yen\", \"name\": \"Anne\", \"fromDate\": \"2022-02-01T00:00:00\" }, { \"payrollUnit\": \"usd\", \"name\": \"James\", \"fromDate\": \"2022-12-01T00:00:00\" }, { \"payrollUnit\": \"euro\", \"fromDate\": \"2022-06-01T00:00:00\", \"name\": \"Thelma\" } ]";

var context = new JUSTContext() { SplitGroupChar = '|' };
var result = new JsonTransformer(context).Transform(transformer, input);

Assert.AreEqual("{\"Result\":[{\"payrollUnit\":\"euro\",\"fromDate\":\"2022-01-01T00:00:00\",\"all\":[{\"name\":\"John\"},{\"name\":\"Smith\"}]},{\"payrollUnit\":\"usd\",\"fromDate\":\"2022-01-01T00:00:00\",\"all\":[{\"name\":\"Lucy\"}]},{\"payrollUnit\":\"yen\",\"fromDate\":\"2022-02-01T00:00:00\",\"all\":[{\"name\":\"Anne\"}]},{\"payrollUnit\":\"usd\",\"fromDate\":\"2022-12-01T00:00:00\",\"all\":[{\"name\":\"James\"}]},{\"payrollUnit\":\"euro\",\"fromDate\":\"2022-06-01T00:00:00\",\"all\":[{\"name\":\"Thelma\"}]}]}", result);
}
}
}