Editor: Introduce new API method that register block from block.json metadata file#346
Closed
gziolo wants to merge 5 commits intoWordPress:masterfrom
gziolo:add/register-block-type-metadata
Closed
Editor: Introduce new API method that register block from block.json metadata file#346gziolo wants to merge 5 commits intoWordPress:masterfrom gziolo:add/register-block-type-metadata
block.json metadata file#346gziolo wants to merge 5 commits intoWordPress:masterfrom
gziolo:add/register-block-type-metadata
Conversation
ocean90
requested changes
Jun 22, 2020
Member
ocean90
left a comment
There was a problem hiding this comment.
DocBlocks needs some minor formatting updates.
12 tasks
Co-authored-by: Dominik Schilling <dominikschilling+git@gmail.com>
Member
Author
|
@ocean90, is it good to go now? Thank you for review, by the way 👍 |
ocean90
approved these changes
Jun 23, 2020
Member
ocean90
left a comment
There was a problem hiding this comment.
Two minor changes, looks good otherwise.
Co-authored-by: Dominik Schilling <dominikschilling+git@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/50263
This patch includes changes added to Gutenberg in:
register_block_type_from_metadatato handle assets gutenberg#22519This is how the interface looks like:
This function is going to be used to register all blocks on the server when backporting the block editor changes in https://core.trac.wordpress.org/ticket/50420.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.