Enhance template registration e2e tests to handle welcome dialog visibility#68059
Merged
michalczaplinski merged 4 commits intotrunkfrom Dec 18, 2024
Merged
Conversation
…bility Added logic to check for the visibility of the "Welcome to the editor" dialog within 2 seconds before attempting to close it.
michalczaplinski
added
[Type] Code Quality
|
Size Change: 0 B Total Size: 1.84 MB ℹ️ View Unchanged
|
|
Flaky tests detected in c1fbf5a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12393997135
|
Mamaduka
reviewed
Dec 18, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
reviewed
Dec 18, 2024
…d remove the updates to the second test
Member
|
@michalczaplinski, let's also swap |
…de registered templates`e2e test
Contributor
Author
makes sense, done @Mamaduka |
Mamaduka
approved these changes
Dec 18, 2024
Member
Mamaduka
left a comment
Mamaduka
left a comment
There was a problem hiding this comment.
Thanks for the follow-ups, @michalczaplinski!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
In the e2e test for template registration, take into account that the
Welcome to the editordialog might be either open or closed.Why?
In another PR #67289 I found some e2e test failures related to this.
We should check if the
Welcome to the editordialog is actually open before attempting to close it.How?
admin.createNewPost();to create posts instead which internally handles closing the dialog.Testing Instructions
This only updates e2e tests, CI check should be sufficient
Screenshots or screencast