Remove es-module shims and importmap-polyfill#65210
Merged
Conversation
These are no longer used in Core or Gutenberg. See https://core.trac.wordpress.org/ticket/60970
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -12.3 kB (-0.69%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
sirreal
requested review from
DAreRodz,
cbravobernal,
gziolo,
michalczaplinski and
swissspidy
sirreal
added
the
[Type] Task
gziolo
added
the
[Feature] Script Modules API
swissspidy
approved these changes
Sep 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Remove
es-module-shimsdependency andwp-importmap-polyfillinteractivity webpack configuration.These are no longer used in Core or Gutenberg.
See https://core.trac.wordpress.org/ticket/60970
This only seems to have existed in the 6.5 compat directory, which was removed in #64096.
There are no occurances of
wp-polyfill-importmapin the codebase now.Noticed while working on #65064.
Why?
Unused and unnecessary.
How?
Remove them.
Testing Instructions
Search the codebase for mentions. CI builds and e2e tests should pass.