Add an interactive variant to @wordpress/create-block#52508
Closed
luisherranz wants to merge 1 commit intotrunkfrom
Closed
Add an interactive variant to @wordpress/create-block#52508luisherranz wants to merge 1 commit intotrunkfrom
@wordpress/create-block#52508luisherranz wants to merge 1 commit intotrunkfrom
Conversation
luisherranz
added
[Tool] Create Block
Member
Author
|
Another question: This variant requires Gutenberg (16.2+). Where should we inform the user that Gutenberg needs to be installed in other for this to work? |
|
Size Change: 0 B Total Size: 1.43 MB ℹ️ View Unchanged
|
Contributor
|
Given the current state of the Interactivity API package (still experimental), I wouldn't create a Also, ideally, this I think having a direct |
ryanwelcher
reviewed
Jul 11, 2023
Contributor
ryanwelcher
left a comment
ryanwelcher
left a comment
There was a problem hiding this comment.
The code looks good to me. However, I agree with @juanmaguitar that this is probably better as a template until the API is available in core. One benefit of using it's own template is that we can introduce any number of variants to show different and more complex examples
Member
Author
|
Ok, thanks for your feedback. I'll migrate this to a template and we'll merge this variant at a later point 🙂 |
Contributor
|
@luisherranz to speed up things, I have created this PR #52549 over |
Member
Author
|
Awesome. Thank you, Juanma. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Add an
interactivevariant to the@wordpress/create-blockpackage.Why?
So people can use this variant to start testing the Interactivity API.
How?
I followed what @ryanwelcher did in this PR and added a new variant for an
interactiveblock.I also added the possibility of adding a
viewScriptfield to theblock.jsonfile.Testing Instructions
@wordpress/create-blockpackage using:cd packages/create-blocknode index.jsinteractivevariant.block.jsonshould havesupports.interactivity: trueand aviewScriptfield.render.phpfile should contain directives.view.jsfile with an import of@wordpress/interactivityand a call tostore().If you want to try that the interactivity works, you can use
wp-now:cd (installation directory) && npm startnpx @wp-now/wp-now start(in another terminal)Screenshots or screencast
https://www.loom.com/share/3680f3b779e14306b8a7fd5bb484988c
Questions
wp-nowand add npm scripts to run it?