[Block Library]: Update the relationship of No results block to ancestor#48348
[Block Library]: Update the relationship of No results block to ancestor#48348ntsekouras merged 2 commits intotrunkfrom
No results block to ancestor#48348Conversation
|
Was there any discussion about which blocks could benefit from using Actually, it's the only block that uses that API, but in a slightly different way than this PR explores. It also made me wonder whether the Comments block doesn't use |
In various issues at some point, but not a separate issue. We also introduced a new Query Loop PR that wraps these blocks inside
That's a good point and is something we might not want for Post Template... Maybe @ockham or @c4rl0sbr4v0 could share some insights? |
|
+1 This would really be great! It would most likely solve my issue #48296 when I want to use |
…Query Loop to `ancestor`
8a1b889 to
063569b
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ancestorNo results block to ancestor
|
Yeah, good idea to move forward with this change 👍🏻 |
|
Flaky tests detected in 5e67986. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12235468898
|
…cestor` (WordPress#48348) Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org> Co-authored-by: webmandesign <webmandesign@git.wordpress.org>

What?
This PR just add a bit more flexibility to the insertion of
No resultsinside a Query Loop block. Previously you could insert them through the inserter only if they were direct parents of Query Loop, but now they can be inserted in nested blocks(ex Group), as long as they have Query Loop as an ancestor.Similar with: #67657 and #58602
Testing Instructions
Groupand then insert through the inserterNo resultsblock.