Create Block: Refactor handling for template variants#43481
Merged
Conversation
gziolo
force-pushed
the
fix/create-block-variant-polish
branch
from
9abb92d to
447dc7c
Compare
gziolo
added
[Tool] Create Block
|
Size Change: 0 B Total Size: 1.24 MB ℹ️ View Unchanged
|
gziolo
force-pushed
the
fix/create-block-variant-polish
branch
3 times, most recently
from
46e5416 to
0499f46
Compare
gziolo
force-pushed
the
fix/create-block-variant-polish
branch
from
0499f46 to
ed4b796
Compare
adamziel
approved these changes
Aug 23, 2022
Contributor
adamziel
left a comment
adamziel
left a comment
There was a problem hiding this comment.
I read the changes and tried the test plan. It seems to be working as intended, although I didn't dive very deeply.
Member
Author
That's the biggest challenge – testing it extensively. We have basic test coverage for the default template and the es5 one on CI. We could explore integration with e2e tests to ensure that generated blocks work correctly in the editor, but I'm a bit worried that scaffolding takes too long when you need to install npm dependencies for every project started. We could use the local |
bph
added
the
Needs Dev Note
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow-up for #41289, where @ryanwelcher added
--variantflag to allow creation of different block type variants.This PR improves the handling for the
--variantCLI argument to ensure it isn't overridden by the prompt coming from the tool.Why?
Detected that in the interactive mode, the variant selected with the CLI command is ignored (#41289 (comment)). In effect, the following command doesn't fully work as expected as you have to select the same value twice:
How?
Testing Instructions