[RNMobile] Fix path in gutenberg-web-single-block symlink.#30388
Merged
jd-alexander merged 1 commit intoWordPress:trunkfrom Apr 9, 2021
Merged
[RNMobile] Fix path in gutenberg-web-single-block symlink.#30388jd-alexander merged 1 commit intoWordPress:trunkfrom
gutenberg-web-single-block symlink.#30388jd-alexander merged 1 commit intoWordPress:trunkfrom
Conversation
Contributor
|
Just noticed the ping here sorry! @hypest do you mind having a look at it? |
Contributor
|
Thanks for this fix @iandunn these changes will be merged into I will be running some tests and creating supplementary mobile PRs to verify the fix. |
2 tasks
jd-alexander
approved these changes
Apr 9, 2021
Contributor
jd-alexander
left a comment
There was a problem hiding this comment.
@iandunn I tested the symlink fix and the symlink now functions as expected. I will be creating an additional PR to resolve the referenced issues we discovered otherwise. Thanks again for spotting this. LGTM 🚢
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#22714 created packages/react-native-bridge/android/react-native-bridge/src/main/assets/gutenberg-web-single-block, but it looks like the symlink points one folder above where it's intended.
Adding an extra
../should fix it.cc @Tug
How has this been tested?
git checkout trunkcd packages/react-native-bridge/android/react-native-bridge/src/main/assetsls gutenberg-web-single-block, see error that target doesn't existgit checkout {this branch}ls gutenberg-web-single-block, see that target existsI haven't tested beyond that, since I'm not familiar with the mobile side of things. I encountered this when trying to test a GitHub workflow locally with https://github.com/nektos/act/, and got an error from Docker when trying to copy the symlink to its temporary folder. The changes in this PR fixed that.
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).