Fix locked template not updating when inner blocks template prop changes#28007
Merged
Fix locked template not updating when inner blocks template prop changes#28007
Conversation
talldan
added
[Feature] Templates API
|
Size Change: 0 B Total Size: 1.3 MB ℹ️ View Unchanged
|
talldan
commented
Jan 6, 2021
| }; | ||
|
|
||
| registerBlockType( 'test/test-inner-blocks-no-locking', { | ||
| registerBlockType('test/test-inner-blocks-no-locking', { |
Contributor
Author
There was a problem hiding this comment.
For some reason prettier isn't working on these files. I tried the npm run format-js command as well.
Contributor
Author
There was a problem hiding this comment.
I don't think this is a major blocker for the PR.
I had a brief look and couldn't see why this is happening.
Contributor
Author
There was a problem hiding this comment.
#28033 has background and restores formatting and linting.
talldan
requested review from
ajitbohra,
ellatrix,
nerrad and
ntwb
as code owners
diegohaz
approved these changes
Jan 6, 2021
Member
diegohaz
left a comment
diegohaz
left a comment
There was a problem hiding this comment.
Tested the "Test Inner Blocks update locked template" and it works as described. Thanks!
Contributor
Author
|
Thanks for the review! |
|
Thank you talldan for taking the time to resolve my concern. I look forward to the fix in the version hopefully in the 5.6.1 minor release. Thank you again. Kind regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #27897
Adds a missing dependency to ensure template sync update works correctly.
It looks like when this was refactored to a hook the dependency was missed.
How has this been tested?
Added an e2e test.
To manually test:
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: