Add generated block classname to dynamic blocks#24546
Merged
youknowriad merged 1 commit intomasterfrom Aug 17, 2020
Merged
Conversation
youknowriad
added
[Feature] Block API
youknowriad
requested review from
Soean,
TimothyBJacobs,
ajitbohra,
spacedmonkey and
talldan
as code owners
youknowriad
requested review from
Addison-Stavlo,
jorgefilipecosta and
oandregal
|
Size Change: 0 B Total Size: 1.16 MB ℹ️ View Unchanged
|
Contributor
There was a problem hiding this comment.
Nice! I haven't tested all the blocks that have been updated, but this seems to work well and I can verify it is adding the expected class name.
A bit of a side note - I noticed the . edit: nevermind, it sounds like it was an oversight 😄Post Content block never had the expected wp-block-post-content class added to it before, this will add it (but we can always opt it out if necessary). I don't see any reason it shouldn't have the class, but I'm figured I would point it out if others might have any insight on that. 🤔
6 tasks
youknowriad
force-pushed
the
add/generated-classname-server
branch
from
f02b8bd to
a02f75f
Compare
Contributor
Author
|
The dev note here should clarify how this impacts the output of the dynamic blocks. |
tellthemachines
removed
the
Needs Dev Note
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #24483
In different dynamic blocks, we support block default class names in the server in an Adhoc way and now that we have the block-supports handling on the server as well, this PR implements it automatically for all these blocks.
the remaining hook after this PR will be "anchor".
Testing instructions
Check that dynamic blocks render the default block class names
wp-block-*on the frontend.