Chore: Cleanup package-lock.json after Gutenberg Mobile migration#23550
Chore: Cleanup package-lock.json after Gutenberg Mobile migration#23550
Conversation
There was a problem hiding this comment.
jsc-android isn't explicitly used in the package. It's listed as a direct dependency of react-native though.
There was a problem hiding this comment.
I updated node-fetch to the latest version here and in @wordpress/e2e-test-utils.
|
Size Change: 0 B Total Size: 1.13 MB ℹ️ View Unchanged
|
|
There an issue with one of the development dependencies: It looks more like an issue with the In fact, it's licensed as Apache License, Version 2.0: https://github.com/dcporter/didyoumean.js/blob/master/LICENSE Now the question is, whether we should extend the list of allowed values: gutenberg/packages/scripts/scripts/check-licenses.js Lines 78 to 81 in e421896 or explicitly exclude this package from the check? We could also change the logic that scans LICENSE files and use that as fallback when the license is incorrect in It probably would allow us also to remove all the variations people use to describe Apache v2.0 license since those packages most likely have this phrase there. It's the case for |
|
Changing the logic of |
d13ccec to
96365c2
Compare
|
Updated the logic in |
ceyhun
left a comment
There was a problem hiding this comment.
Tested Android and iOS demo apps and they work fine. Thank you for this!
b09bb39 to
7ea622f
Compare


Description
Follow-up for #22714.
This PR tries to hoist all dependencies used in the newly added React Native specific packages.
How has this been tested?
Continues integration – GitHub actions.
Types of changes
Checklist: